Re: Test suite failures in 5.0.2-test-1 _and_ 5.0.2-test-3 on automatic build (was: Re: 5.0.2-test-2 is available)

[Axel Beckert <abe@xxxxxxxxxxxxxxx>]

Hi,

On Mon, Dec 02, 2013 at 09:22:15AM -0800, Bart Schaefer wrote:
> On Dec 2,  5:28pm, Axel Beckert wrote:
> }
> } *** /tmp/zsh.ztst.err.16395	Mon Dec  2 16:15:29 2013
> } --- /tmp/zsh.ztst.terr.16395	Mon Dec  2 16:15:29 2013
> } ***************
> } *** 0 ****
> } --- 1 ----
> } + (eval):setopt:1: can't change option: MONITOR
> 
> This is a tough one to reproduce because I can't manually create a case
> where the MONITOR option can't be reset.
> 
> However, changing the option is non-critical to the test itself, so it's
> only necessary to suppress the extra stderr output.
> 
> Attempting to test this did reveal that acquire_pgrp() can still be caused
> to go into an infinite loop, even after the patch in 31906, if the shell
> that is attempting to assert MONITOR is sufficiently far down the process
> tree from the parent that actually controls the terminal.  I guess that
> loop just needs to give up after a certain number of failed attempts, if
> it really needs to be a loop at all.  (No patch for that yet.)
> 
> diff --git a/Test/A05execution.ztst b/Test/A05execution.ztst
> index ba7e02c..61f6f5a 100644
> --- a/Test/A05execution.ztst
> +++ b/Test/A05execution.ztst
> @@ -179,7 +179,7 @@
>  0:Status reset by starting a backgrounded command
>  >0
>  
> -  setopt MONITOR
> +  { setopt MONITOR } 2>/dev/null
>    [[ -o MONITOR ]] || print -u $ZTST_fd 'Unable to change MONITOR option'
>    repeat 2048; do (return 2 |
>                     return 1 |

Still fails, now looks like this:

http://jenkins.grml.org/view/Debian/job/zsh-binaries/92/architecture=i386/console

../../Test/A05execution.ztst: starting.
Unable to change MONITOR option
*** /tmp/zsh.ztst.err.1283	Mon Dec  2 18:04:46 2013
--- /tmp/zsh.ztst.terr.1283	Mon Dec  2 18:04:46 2013
***************
*** 0 ****
--- 1 ----
+ (eval):setopt:1: can't change option: MONITOR
Test ../../Test/A05execution.ztst failed: error output differs from expected as shown above for:
  setopt MONITOR
  externFunc() { awk >/dev/null 2>&1; true; }
  false | true | false | true | externFunc
  echo $pipestatus
Was testing: Check $pipestatus with a known difficult case
../../Test/A05execution.ztst: test failed.
The following may (or may not) help identifying the cause:
  This similar test was triggering a reproducible failure with pipestatus.
../../Test/A06assign.ztst: starting.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@xxxxxxxxxxxxxxx  (Mail)
 X   See http://www.asciiribbon.org/              | abe@xxxxxxxxx (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)