Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Anybody know what's going on here in _expand? Patch?

X-seq: zsh-workers 32187
From: "Jun T." <takimoto-j@xxxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxx
Subject: Re: Anybody know what's going on here in _expand? Patch?
Date: Sat, 28 Dec 2013 00:08:46 +0900
In-reply-to: <131226170827.ZM31040@torch.brasslantern.com>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <131226170827.ZM31040@torch.brasslantern.com>

> then I propose the following patch, which adds the seemingly missing
> backreference parens as well as putting quote chars in the class.

I believe the lack of the backreference paren is definitely a bug.

I guess the reason that this seemingly-rather-serious bug has not
been noticed so far is:

match[1] is set at lines 90-91 (where the pattern has a correct
pair of back-reference parentheses), and its value is NOT rest at
line 106 (where there are no back-reference parentheses).
The value is re-used at line 107, and in many (or all?) cases the
value is correct (a single space for most of the cases).

References:
- Anybody know what's going on here in _expand? Patch?
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author