Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: zle: vi mode: wrong undo handling on fresh lines
- X-seq: zsh-workers 32361
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: zle: vi mode: wrong undo handling on fresh lines
- Date: Fri, 07 Feb 2014 15:43:56 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s1024; t=1391784238; bh=jl0fsRx3wRebwDBNr/cfyHUcE6gAf1GBHL2qJKdZdWI=; h=Received:Received:Received:DKIM-Signature:X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Received:In-reply-to:From:References:To:Subject:MIME-Version:Content-Type:Content-ID:Date:Message-ID; b=xXv3mKCxxFe3F6SZcm7JZXFHB+B/SW8LNbNiezjnEa7xdi7IJB1Mo8KfnXU4lOMWOhU5ncMwQCebAYx2esRbTDmZIzmc32/jvv/OIU1rIxzTNtarIhXJaaVbOcVSD+l7jtau+PklsgVlTqBwrPu6ZWw6pkE8C9K3Ih1loGA1gYM=
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s1024; t=1391784238; bh=jl0fsRx3wRebwDBNr/cfyHUcE6gAf1GBHL2qJKdZdWI=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Received:In-reply-to:From:References:To:Subject:MIME-Version:Content-Type:Content-ID:Date:Message-ID; b=t9p9Mt+k+MY56tTI27rW31F/BvxqHufi1gP3dc7TukLjRwWhTNAS+nNMQKtRDRjGeL4xnt+5OnD3sTSLFOL5CQLjJtpynFLUYXbJkwQKVVHXjwJYh2gOib5IRcjbmfYApyo7xMBFybSrpQT2sc//jLjCrOsxYe1aJg4O/+P+7aQ=
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.co.uk; b=yBNKj8lkuIZ31MjdlFkcKur7hapw1eoRjj28///7YBixt94+qBzOOdLbx2ssNp8dKHVoyty91WBRVqwFOVDMX2tUY7ynPQlfEBAfXDrrj2x5+7KACaxjrhSIR0mu0QALnDX+IyF0m+GrQ0JE36aIKLgUhdwyfw7SK2YzsFS5Jz4=;
- In-reply-to: <2700.1390950035@thecus.kiddle.eu>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CANWLQWsV5i+=3NptAxir6UYCoipFa2Pk+g6D1DDnMnJMVCbDgA@mail.gmail.com> <20130923213014.15f97f9e@pws-pc.ntlworld.com> <3511.1390605547@thecus.kiddle.eu> <140125111530.ZM21792@torch.brasslantern.com> <20140127124301.4144f2d9@pwslap01u.europe.root.pri> <20140127161124.2aa16b37@pwslap01u.europe.root.pri> <2700.1390950035@thecus.kiddle.eu>
On 29 Jan, I wrote:
> +++ b/Src/Zle/zle_tricky.c
> @@ -611,8 +611,7 @@ docomplete(int lst)
> - if (undoing)
> - setlastline();
> + setlastline();
I have a widget that adds text to LBUFFER and invokes completion.
The text added to LBUFFER can't be undone with this change and with
emacs mode, the problem was there before. I think this line should just
be removed as it doesn't make much sense anyway.
It was added in workers/8590 (a reply to 8574). Removing it doesn't seem
to cause problems that I can find though the examples in 8574 seem
broken in other ways.
Oliver
diff --git a/Src/Zle/zle_tricky.c b/Src/Zle/zle_tricky.c
index a12fa08..3c7cff9 100644
--- a/Src/Zle/zle_tricky.c
+++ b/Src/Zle/zle_tricky.c
@@ -611,7 +611,6 @@ docomplete(int lst)
active = 1;
comprecursive = 0;
makecommaspecial(0);
- setlastline();
/* From the C-code's point of view, we can only use compctl as a default
* type of completion. Load it if it hasn't been loaded already and
Messages sorted by:
Reverse Date,
Date,
Thread,
Author