Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
[PATCH] Add CORRECT_IGNORE_NAME for file names pattern ignored during CORRECT_ALL
- X-seq: zsh-workers 32578
- From: Tomoki Sekiyama <tomoki.sekiyama@xxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: [PATCH] Add CORRECT_IGNORE_NAME for file names pattern ignored during CORRECT_ALL
- Date: Thu, 24 Apr 2014 18:05:15 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=PA6AKNNvuVmE3PqBXL+xDnP9JJh6jbVt9torNlDZvJg=; b=IrODj0NbB3jYzURNNLnUSHTihYZe7qCfgcenxPxG5CzRjKj/szurQfoRVOWBHyBTwD NzS2/IJ72KC6BGFKUGtraJ0KNP5CwnyXFNrnODqNIPkQldvayKRNwz7hiWqHDBz/p9Fi kaZFZOfUgsbdia7Htc5pv1we1Cxh7L78lCZxAOb2BrD0pPSVcnOsY9E+Vv9EcW7j+ubL /CQpH0/kdQu4tuEFtc6gS5qLQBJHyC3z0JUFJRxv9jufDgCtc26b9M0n/64ZzsiD2JvP g9Q0drsMQvLzrsy5OOf7xSMkVD0rwahCxC39ifUSMR6NStQd1+OCcdJb2yN1YdwkknI1 C3Hw==
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
When CORRECT_ALL is enabled, spell checking for file names may suggest
unwanted correction for command arguments. For example, if a file named
'.status' exists in current directory, `git status' will ask:
zsh: correct 'status' to '.status' [nyae]?
With this patch, we can avoid this by set CORRECT_IGNORE_NAME shell variable
to '.*', that means dotfile names shouldn't be suggested.
---
Doc/Zsh/options.yo | 3 +++
Doc/Zsh/params.yo | 7 +++++++
Src/utils.c | 11 ++++++++++-
3 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/Doc/Zsh/options.yo b/Doc/Zsh/options.yo
index fbcf28c..96df041 100644
--- a/Doc/Zsh/options.yo
+++ b/Doc/Zsh/options.yo
@@ -1098,6 +1098,9 @@ pindex(CORRECTALL)
pindex(NOCORRECTALL)
item(tt(CORRECT_ALL) (tt(-O)))(
Try to correct the spelling of all arguments in a line.
+
+The shell variable tt(CORRECT_IGNORE_NAME) may be set to a pattern to
+match file names that will never be offered as corrections.
)
pindex(DVORAK)
pindex(NO_DVORAK)
diff --git a/Doc/Zsh/params.yo b/Doc/Zsh/params.yo
index 8d95355..f01c4bd 100644
--- a/Doc/Zsh/params.yo
+++ b/Doc/Zsh/params.yo
@@ -917,6 +917,13 @@ of file names, as applied by the tt(CORRECT_ALL) option (so with the
example just given files beginning with `tt(_)' in the current
directory would still be completed).
)
+vindex(CORRECT_IGNORE_NAME)
+item(tt(CORRECT_IGNORE_NAME))(
+If set, is treated as a pattern during spelling correction of file names.
+Any file names correction that matches the pattern is ignored. For example,
+if the value is `tt(.*)' then dot file names will never be offered
+as spelling corrections. This is useful with the tt(CORRECT_ALL) option.
+)
vindex(DIRSTACKSIZE)
item(tt(DIRSTACKSIZE))(
The maximum size of the directory stack, by default there is no limit. If the
diff --git a/Src/utils.c b/Src/utils.c
index e1fd7a3..c092464 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -2491,7 +2491,7 @@ getquery(char *valid_chars, int purge)
static int d;
static char *guess, *best;
-static Patprog spckpat;
+static Patprog spckpat, spnamepat;
/**/
static void
@@ -2562,6 +2562,13 @@ spckword(char **s, int hist, int cmd, int ask)
} else
spckpat = NULL;
+ if ((correct_ignore = getsparam("CORRECT_IGNORE_NAME")) != NULL) {
+ tokenize(correct_ignore = dupstring(correct_ignore));
+ remnulargs(correct_ignore);
+ spnamepat = patcompile(correct_ignore, 0, NULL);
+ } else
+ spnamepat = NULL;
+
if (**s == String && !*t) {
guess = *s + 1;
if (itype_end(guess, IIDENT, 1) == guess)
@@ -3783,6 +3790,8 @@ mindist(char *dir, char *mindistguess, char *mindistbest)
if (!(dd = opendir(unmeta(dir))))
return mindistd;
while ((fn = zreaddir(dd, 0))) {
+ if (spnamepat && pattry(spnamepat, fn))
+ continue;
nd = spdist(fn, mindistguess,
(int)strlen(mindistguess) / 4 + 1);
if (nd <= mindistd) {
--
1.9.0
Messages sorted by:
Reverse Date,
Date,
Thread,
Author