Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
[PATCH] vcs_info svn: 'Fix set-branch-format' when in subdirs
- X-seq: zsh-workers 32621
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: [PATCH] vcs_info svn: 'Fix set-branch-format' when in subdirs
- Date: Sun, 25 May 2014 21:56:26 +0000
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:subject:message-id :mime-version:content-type; s=mesmtp; bh=raQ6TCHsVc25im6+ZrDDZF5 bLbU=; b=wV7zB57Da+LeiwEM1+1q+zyL7D5fmu/ip18ydCcaqlMWo1sstTNpJV+ 6HYUkB3iQjKSCCHjlz/q9/bf95rD7/UebxT++sNUlDKT0TYtLQERDc3vxndcgdl5 +gZWi2E3jCvAo8pFs+PA3ZPzbvfRV36GKvcTcWzxc3gOd5ay8XLE=
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :mime-version:content-type; s=smtpout; bh=raQ6TCHsVc25im6+ZrDDZF 5bLbU=; b=rEPDsSMTvhSDgil3mLK5afJGbqdmkeTyLP18cSTmMYhoupcHV6AE2D kVXVdpZfxY6SDMTYTy/WQd2g4IogJUk3Y3LMmwWhegg/5hezWvY//Jnpslynzm4k 6PJ31jufKGpRl5YbZhhNfi+4DLUVkcaZJy3zzMqPQhGNQN4j0xD+s=
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
The previous code would fail to detect the wcroot with Subversion 1.7+
when cwd is at least two levels below the root (i.e., ../../.svn exists
and ../.svn doesn't), and would then pass to the hook the revision and
basename of cwd rather than of the wcroot.
---
Two caveats:
1. This patch will conflict if applied before the other patch I just
sent. The conflict is syntactic, not semantic, and only affects hunk
context lines.
2. I haven't tested this patch in any way.
Functions/VCS_Info/Backends/VCS_INFO_get_data_svn | 22 ++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/Functions/VCS_Info/Backends/VCS_INFO_get_data_svn b/Functions/VCS_Info/Backends/VCS_INFO_get_data_svn
index ae3c499..e56afee 100644
--- a/Functions/VCS_Info/Backends/VCS_INFO_get_data_svn
+++ b/Functions/VCS_Info/Backends/VCS_INFO_get_data_svn
@@ -30,13 +30,21 @@ done
cwdinfo=(${(kv)svninfo})
-while [[ -d "${svnbase}/../.svn" ]]; do
- parentinfo=()
- ${vcs_comm[cmd]} info --non-interactive "${svnbase}/.." | while IFS=: read a b; do parentinfo[${a// /_}]="${b## #}"; done
- [[ ${parentinfo[Repository_UUID]} != ${svninfo[Repository_UUID]} ]] && break
- svninfo=(${(kv)parentinfo})
- svnbase="${svnbase}/.."
-done
+# Set svnbase to the wcroot path and svninfo to its `svn info`.
+if (( ${+svninfo[Working_Copy_Root_Path]} )); then
+ # svn 1.7+
+ svnbase=${svninfo[Working_Copy_Root_Path]}
+ ${vcs_comm[cmd]} info --non-interactive -- "${svnbase}" | while IFS=: read a b; do svninfo[${a// /_}]="${b## #}"; done
+else
+ # svn 1.0-1.6
+ while [[ -d "${svnbase}/../.svn" ]]; do
+ parentinfo=()
+ ${vcs_comm[cmd]} info --non-interactive -- "${svnbase}/.." | while IFS=: read a b; do parentinfo[${a// /_}]="${b## #}"; done
+ [[ ${parentinfo[Repository_UUID]} != ${svninfo[Repository_UUID]} ]] && break
+ svninfo=(${(kv)parentinfo})
+ svnbase="${svnbase}/.."
+ done
+fi
svnbase="$(VCS_INFO_realpath ${svnbase})"
--
1.7.10.4
Messages sorted by:
Reverse Date,
Date,
Thread,
Author