Re: zsh 5.0.5-dev-2

[Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>]

On Thu, 14 Aug 2014 09:20:45 -0700
Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> On Aug 14, 10:32am, Peter Stephenson wrote:
> } Subject: Re: zsh 5.0.5-dev-2
> }
> } > > Can we perhaps just remove or comment out that one error message for a
> } > > release?
> } > 
> } > zsh -fw
> } > cd /
> } > zsh: path expansion failed, using root directory
> } > 
> } > We certainly need to do something.  But if this is the only issue, can't
> } > it be straightforwardly fixed like this?
> } 
> } If someone can reassure me that the weird undocumented interaction with
> } xbuf bypassing parameter passing starts here --- i.e. we are resetting
> } xbuf here, then xsymlinks fiddles with it and this code looks at the
> } result --- then I can't see how this change can be wrong as far as it
> } goes.  The question is, is there more to it?
> 
> I don't have time to compose a more thorough response here, but I think
> this may have been discussed in the previous thread.

Yes, it says anything that resolves to the root directory has the same
problem.

It's entirely unclear to me from looking at xsymlinks() when an empty
xbuf would actually constitute a failure.  If it can't expand something
as a symbolic link it simply treats it literally; and any number of ".."
is valid in a path.  There's no stat so it doesn't care if the path
actually exists.  I don't think we worry about "superroots" any more.

If we don't have an answer now I'd be inclined to comment out the
warning.

pws