Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Misc patches for git completion and vcs_info

X-seq: zsh-workers 33157
From: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>
To: Marc Finet <m.dreadlock@xxxxxxxxx>
Subject: Re: Misc patches for git completion and vcs_info
Date: Sat, 13 Sep 2014 14:23:00 +0200
Cc: zsh-workers@xxxxxxx
In-reply-to: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com> (Marc Finet's message of "Fri, 12 Sep 2014 23:30:34 +0200")
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com>

Hey Marc,

Marc Finet wrote:
> Below is a list of patches that i added in my current zsh (based on
> tonight's master). Please consider them for review as my zsh-level is
> currently very low (e.g. patch 2) and i might have broken other use-cases
> (patch 4 for instance makes me a little bit nervous as it seems to easy).

I'll take a look at the vcs_info related ones as soon as I can; most
look straightforward, though. I'm so far only unsure about the patches
that touch the quilt backend (well, and the big one, 8/9, which I didn't
look at, yet, at all).

git-completion patches: The one about _confirm vs. _confirm_values is
correct, since __git_sendemail_confirm() doesn't even exist.

The one about the alias completion, is a bit more complex, obviously. I
don't have multi-line aliases set in my git-configuration, so I'll take
your word for it. :-)

Regards, Frank

References:
- Misc patches for git completion and vcs_info
  - From: Marc Finet

Messages sorted by: Reverse Date, Date, Thread, Author