Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 5/9] vcs_info quilt: fix standalone detection

X-seq: zsh-workers 33165
From: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>
To: Marc Finet <m.dreadlock@xxxxxxxxx>
Subject: Re: [PATCH 5/9] vcs_info quilt: fix standalone detection
Date: Sun, 14 Sep 2014 11:42:55 +0200
Cc: zsh-workers@xxxxxxx
In-reply-to: <1410557443-24178-6-git-send-email-m.dreadlock@gmail.com> (Marc Finet's message of "Fri, 12 Sep 2014 23:30:39 +0200")
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com> <1410557443-24178-6-git-send-email-m.dreadlock@gmail.com>

Marc Finet wrote:
[...]
> -    if [[ -n "${file}" ]]; then
> -        oldfile=${vcs_comm[detect_need_file]}
> -        vcs_comm[detect_need_file]=${file}
> -    fi
> +    oldfile=${vcs_comm[detect_need_file]}
> +    vcs_comm[detect_need_file]=${file}
>      VCS_INFO_bydir_detect ${dir}
>      ret=$?
> -    [[ -n "${file}" ]] && vcs_comm[detect_need_file]=${oldfile}
> +    vcs_comm[detect_need_file]=${oldfile}

I don't think this changes anything really, but the removing the
conditionals makes the code a bit easier to read. So ACK.


Regards, Frank

Follow-Ups:
- Re: [PATCH 5/9] vcs_info quilt: fix standalone detection
  - From: Marc Finet

References:
- Misc patches for git completion and vcs_info
  - From: Marc Finet
- [PATCH 5/9] vcs_info quilt: fix standalone detection
  - From: Marc Finet

Messages sorted by: Reverse Date, Date, Thread, Author