Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
PATCH: keep region active when widget fails
- X-seq: zsh-workers 33624
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- To: Zsh workers <zsh-workers@xxxxxxx>
- Subject: PATCH: keep region active when widget fails
- Date: Fri, 07 Nov 2014 00:48:23 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1415317705; bh=vMIL56Z3iaMBu0BnrL6VjxxHjytL/mJV+SphtRex/R4=; h=From:To:Subject:Date:From:Subject; b=Ry5O7MT9O/8qc+dEjYfsC16xZ+EsM1xxH11Ju3zUb9i0vBC+UBcDt5G8kryVKmqe31RfRgHgwnT/MHYfzl8pxtojNbsIvGsRj2jeDqFM1g7MU+z/41v3koDiqUEiH1iDP2vwiyDIfGplNVVhDb20TGPOhsrib98SKmXsYVbIz/SQNP2Er/OnfjZre/uE9NGg1LFnFJ0dACkW7933ZhXbwTzKgnLAMXRm1L12KtD894Zh/ivx6w3dNGcrGGKad8EygbvUMKH8UVzDXcMftTY7te3WNPN/GvDeM9LCAT9SJpd2hlXxtsDjQAoF3vOYKBF686Dgls4KV2M7jKlHKHKAng==
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.co.uk; b=prgbg+o9C1ABCJpybrU0UDY1JWQeWUmlRefFpEspiesV536bYPo1Ma3LsmSmRqM461JrYoeJaW23DCNHALhSre6+J2WaXAjRwPsR//Yu9oszx36FU4L7k0KGGfzcZv42cx4DnchcD5/Zf2Ctst7PasRfIBSbb6+egyRE4tHy3RunPHwtrQGOqS9bnT5Qij2HvGFEoQuxZUYGSISPQhTmT9DZoFqnhNyJxXlpLN+btDipqQKwmToawLESj6092h9pcuo5ytcBwmA7fbLTZHjShBaf7wMneKPMX7cSeTH4MDUBYp8Fq/MXtVT9V1CXAokcuWewv/y3AmfmQGXb4WD/xA==;
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
Does anyone know why we set region_active to false in handlefeep()? I
would guess that there are perhaps cases where we want this but things
like cursor left when you're already in the first position shouldn't
unset region_active. Any objections to the following patch? We can
always add the assignment to individual widgets if we find cases where
it is desirable.
Oliver
diff --git a/Src/Zle/zle_utils.c b/Src/Zle/zle_utils.c
index e95a34b..03a2bdc 100644
--- a/Src/Zle/zle_utils.c
+++ b/Src/Zle/zle_utils.c
@@ -1365,7 +1365,6 @@ int
handlefeep(UNUSED(char **args))
{
zbeep();
- region_active = 0;
return 0;
}
Messages sorted by:
Reverse Date,
Date,
Thread,
Author