Re: Interrupting globs (Re: Something rotten in tar completion)

[Oliver Kiddle <okiddle@xxxxxxxxxxx>]

Peter wrote:
> 
> It's also just occurred to me I may have introduced some rare but
> entirely possible read-modify-write races because we set the ERRFLAG_INT
> bit in interrupts and set the other and clear both bits separately in
> the main shell.  I guess it would be better to queue interrupts whenever
> we add or remove a single bit of errflag; that's probably not often
> enough to cause efficiency issues since should only be round significant
> chunks of shell code, or when an error has actually occurred.  Opinions?

Could that perhaps be solved by making errflag a volatile sig_atomic_t
instead of an int?

Oliver