Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: zsh history bug ?



On Fri, Dec 12, 2014 at 11:11 AM, Bernhard Tittelbach <xro@xxxxxxxxxxx> wrote:
> Am 2014-12-12 um 11:01 schrieb Mikael Magnusson:
>> On Fri, Dec 12, 2014 at 10:48 AM, Bernhard Tittelbach <xro@xxxxxxxxxxx> wrote:
>>> Am 2014-12-10 um 18:19 schrieb Bart Schaefer:
>>>> On Dec 10,  6:23am, Bernhard Tittelbach wrote:
>>>>
>>>> I'm not able to reproduce this on MacOS (the platform where the bug
>>>> originally was reported, IIRC).
>>>>
>>>> Here was the patch:
>>>>
>>>> 2013-09-26  Barton E. Schaefer  <schaefer@xxxxxxx>
>>>>
>>>>         * 31770: Src/hist.c: memmove() instead of memcpy() for overlapping
>>>>         regions.
>>>>
>>>> I've re-checked Src/hist.c and there are no other cases where memcpy() is
>>>> being used except with a newly-allocated buffer as the destination (so, no
>>>> overlapping regions).
>>>>
>>>> } >> When I previously encountered the bug, I believe only the lookup from
>>>> } >> history was garbled, i.e. the contents of .zsh_history were fine.
>>>> } >> I'll have to confirm this on a different system though.
>>>>
>>>> Are you sharing history via a network-mounted home directory from
>>>> multiple hosts?
>>> The home directories are on local drives only.
>>> I don't share history between computers at all.
>>>> [...]
>>> Originally, on the x86_64 machine, I was running zsh 5.0.3 from the
>>> Ubuntu Package,
>>> but per your suggestion I compiled 5.0.7 from source last month. The bug
>>> persisted until
>>> Mikael suggested setting "nohistreduceblanks" i.e. disabling
>>> "histreduceblanks"
>>>
>>> Since then I've not encountered the bug anymore or at least the bug has
>>> become so seldom
>>> I've not encountered it yet again within the last month. Previously It
>>> appeared about once in a day of work on the shell.
>> Are you totally sure there were no more 5.0.3 instances running at
>> that time? Or are you saying it works with histreduceblanks enabled
>> again?
>>
>
> I'm saying If I enable histreduceblanks, the bug is present.
> Regardles of the zsh version. Both 5.0.3 and 5.0.7 are affected.

And just to make sure, if you run
echo $ZSH_VERSION
in a shell, it displays 5.0.7? (We had an instance recently in #zsh
where someone upgraded, but their login shell was actually /bin/zsh5,
and they used zsh --version to check the version).

-- 
Mikael Magnusson



Messages sorted by: Reverse Date, Date, Thread, Author