Re: [PATCH] _git: Respect tags for subcommand completion.

[Mikael Magnusson <mikachu@xxxxxxxxx>]

On Tue, Dec 23, 2014 at 1:27 AM, Oliver Kiddle <okiddle@xxxxxxxxxxx> wrote:
> Mikael Magnusson wrote:
>> > Attached a patch to improve the 'git <TAB>' user experience.
>>
>> Could you write a few words about what the patch actually does? Eg,
>> what's wrong with the current status quo?
>
> Did you perhaps not notice the subsequent text in the lead up to the
> patch?
>
> The current code is not using a single tag loop for all of the different
> types of commands. The default behaviour won't change much but with
> the tag-order style, you will be able to reorder the commands or have
> certain types only completed if others don't match or if _next_tags is
> invoked.

I did see it, but I didn't understand what difference it would make
since I already successfully use tag-order with _git. I see now though
that it only works because I hide some tags, I don't reorder anything.
(eg, with the - '! plumbing-blabla' syntax).

-- 
Mikael Magnusson