Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH 06/17: compctl: Remove pointless check

X-seq: zsh-workers 34124
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: <zsh-workers@xxxxxxx>
Subject: Re: PATCH 06/17: compctl: Remove pointless check
Date: Mon, 05 Jan 2015 23:53:02 -0800
In-reply-to: <1420521949-30483-7-git-send-email-mikachu@gmail.com>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <1420521949-30483-1-git-send-email-mikachu@gmail.com> <1420521949-30483-7-git-send-email-mikachu@gmail.com>

On Jan 6,  6:25am, Mikael Magnusson wrote:
} Subject: PATCH 06/17: compctl: Remove pointless check
}
} cc has already been derefed a bunch of times leading up to here. Found
} by Coverity (Issue 1255841).
} -    if (cc && cc->xor) {
} +    if (cc->xor) {

I'm curious, why bother to "fix" this (and a couple of similar others in
later patches in this series)?  It's not *wrong*, and the change is not
a significant optimization.

Follow-Ups:
- Re: PATCH 06/17: compctl: Remove pointless check
  - From: Kamil Dudka
- Re: PATCH 06/17: compctl: Remove pointless check
  - From: Mikael Magnusson

References:
- Some valgrind patches
  - From: Mikael Magnusson
- PATCH 06/17: compctl: Remove pointless check
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author