Re: PATCH (differently) Re: PATCH: Plug some fd leaks in bin_print

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On Jan 7,  9:26am, Mikael Magnusson wrote:
} Subject: Re: PATCH (differently) Re: PATCH: Plug some fd leaks in bin_prin
}
} On Wed, Jan 7, 2015 at 8:14 AM, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
} > On Jan 6, 11:08pm, Bart Schaefer wrote:
} > }
} > } Does coverity still find leaks after this?  What I've done is to move
} > } option validity checking earlier in the function so that fout should
} > } never get opened in the first place if we're not going to make proper
} > } use of it later.
} 
} Only Clint and Oliver have admin access, so I can't actually upload
} new code to coverity to check. Maybe if either of them see this they
} could add me/us as admins too?

I can push this to the master git a bit later today if nobody sees any
obvious problems with it.  "make check" does still pass.

You can see from that one hunk that the precedence of options is a bit
wacky.  -c / -C win if there is no format string but -z / -s win if
there is one.  I guess that sort of makes sense because columnation of
formatted output isn't supported.