Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
PATCH: unwanted error aborting continued command substitution
- X-seq: zsh-workers 34905
- From: Peter Stephenson <p.stephenson@xxxxxxxxxxx>
- To: zsh workers <zsh-workers@xxxxxxx>
- Subject: PATCH: unwanted error aborting continued command substitution
- Date: Fri, 17 Apr 2015 10:16:00 +0100
- In-reply-to: <CAHYJk3T2jd238ZCh1mtNorNKZJ0H8U6wQeTA_VYX2aDiXmAt=w@mail.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- Organization: Samsung Cambridge Solution Centre
- References: <CAHYJk3T2jd238ZCh1mtNorNKZJ0H8U6wQeTA_VYX2aDiXmAt=w@mail.gmail.com>
On Fri, 17 Apr 2015 06:39:29 +0200
Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> % $(
> cmdsubst> [press ctrl-c here]
> zsh: parse error near `$('
>
> I would expect to not get an error message about syntax after pressing
> ctrl-c.
I think that means we can handle this case as part of a general tidy up
rather than agonising over the complexities of the nested parsing ---
which means we can reap the benefit [sorry, leverage the synergy] of
breaking out the interrupt flag. The following looks plausible, though
the interactions are complicated.
I believe the fix for only resetting the interrupt flag when resetting
the local keymap if there actually *was* a local keymap has to be
correct, but you never quite know if there are scary special cases that
use things differently...
pws
diff --git a/Src/Zle/zle_keymap.c b/Src/Zle/zle_keymap.c
index cfef882..c6fae25 100644
--- a/Src/Zle/zle_keymap.c
+++ b/Src/Zle/zle_keymap.c
@@ -503,8 +503,9 @@ selectkeymap(char *name, int fb)
mod_export void
selectlocalmap(Keymap m)
{
+ Keymap oldm = localkeymap;
localkeymap = m;
- if (!m)
+ if (oldm && !m)
{
/*
* No local keymap; so we are returning to the global map. If
diff --git a/Src/lex.c b/Src/lex.c
index 184a54b..c929bb9 100644
--- a/Src/lex.c
+++ b/Src/lex.c
@@ -1558,10 +1558,12 @@ parsestr(char **s)
if ((err = parsestrnoerr(s))) {
untokenize(*s);
- if (err > 32 && err < 127)
- zerr("parse error near `%c'", err);
- else
- zerr("parse error");
+ if (!(errflag & ERRFLAG_INT)) {
+ if (err > 32 && err < 127)
+ zerr("parse error near `%c'", err);
+ else
+ zerr("parse error");
+ }
}
return err;
}
diff --git a/Src/parse.c b/Src/parse.c
index 0b54a90..91a81e1 100644
--- a/Src/parse.c
+++ b/Src/parse.c
@@ -2419,7 +2419,7 @@ yyerror(int noerr)
for (t0 = 0; t0 != 20; t0++)
if (!t || !t[t0] || t[t0] == '\n')
break;
- if (!(histdone & HISTFLAG_NOEXEC)) {
+ if (!(histdone & HISTFLAG_NOEXEC) && !(errflag & ERRFLAG_INT)) {
if (t0 == 20)
zwarn("parse error near `%l...'", t, 20);
else if (t0)
Messages sorted by:
Reverse Date,
Date,
Thread,
Author