Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: _fc: Remove a spurious 2
- X-seq: zsh-workers 34940
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: PATCH: _fc: Remove a spurious 2
- Date: Tue, 21 Apr 2015 00:24:08 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1429568649; bh=n58Ex0PdkCfVRr9Yr4QZXr5BfO1j7Ohoe6MPgpv2mFo=; h=To:In-reply-to:From:References:Subject:Date:From:Subject; b=Qc+aERFLiDPxcpwvyD2dgv6pEveTNdHUcnEgrxftHNC1DTJN1OfOE0TjMyMJm0oEFaOMgvo9M0qrK4Ay2HHPocIbOgVQ2bneScceBwAaSBlt0+F0Y4vT0W212XuuyQfXAxYcCXiNbcU4com2ZsyXUQHOK9VmpU+kPf60dtEa1cDIdbdqUE3Vxeagv0GVqZi5swZoCOPNztKSnsG9jcSk7qO7bkEl0qtndJbkmmiL3ZK5+K33wEuBV1m/2qp/Z0dPqh6pmtpgtTHODsTX551aAhJBhOTXzTVPuvGFzbcXPdiJ/lya9LBB4yKkAnaVUe1nWzu7BRwaxWa9WHKJE4KwjA==
- In-reply-to: <1429372196-6153-1-git-send-email-mikachu@gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <1429372196-6153-1-git-send-email-mikachu@gmail.com>
Mikael Magnusson wrote:
> AFAICS, -2 isn't an option more than any other number is, and this broke
> history -<tab> completion.
That 2 is not spurious. It excludes the second argument, i.e. the
_arguments specification '2:last event:->events'
You can only have one argument after -m.
I think completion for history (as opposed to fc) is broken for quite a
different reason, see the following patch.
Oliver
diff --git a/Completion/Zsh/Command/_fc b/Completion/Zsh/Command/_fc
index 1331456..c298721 100644
--- a/Completion/Zsh/Command/_fc
+++ b/Completion/Zsh/Command/_fc
@@ -49,7 +49,7 @@ fc_r='(-A -R -W -I -e)-l[list resulting commands on stdout]'
case $service in
history)
- _arguments "$fc_common[@]" "$fc_hist[@] && ret=0"
+ _arguments "$fc_common[@]" "$fc_hist[@]" && ret=0
;;
r)
_arguments "$fc_common[@]" "$fc_r" && ret=0
Messages sorted by:
Reverse Date,
Date,
Thread,
Author