Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: Fix two bugs in typeset_setbase
- X-seq: zsh-workers 35022
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: zsh workers <zsh-workers@xxxxxxx>
- Subject: Re: PATCH: Fix two bugs in typeset_setbase
- Date: Sun, 3 May 2015 22:43:46 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=eAemN9+qFr+QfsURyKXCPSDmCe1on9qJJsN+GpZ6Qy4=; b=sMBQaJw2wJzjP/a/nwamqPqy8hgzB+3BgKYziGgrPpnRdK8ERpYXBgLkE9aulkal89 8sBNZwJlCLd8AY+kypVHd2a2hm0dMgXYDPZvWCTHzXAqv5Zq2HBE2Qi9oaGE7sAaVMf7 ppfOKZ7YUh8CCvgRd/YI4CbsnxU64BwOfryu9+IsOeAxYD46m6CGPtC8fP6KwuFmR+wn 5pDNRzmaqtf/nEimkZ7cBoBKIUwvSm6wjl9UTLEvXI0vnfdiPY/A7EZ8kI+GnOT4tipB QxI51b8e6irIpENrVmeEurco01fOY8St3Me+CZumTtL6N9KnauUVvX22xAAjKqBaMORy fNJA==
- In-reply-to: <1430685362-12270-1-git-send-email-mikachu@gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CAOcd6hrtTa7WVerarsU9+ZTWxa5G0g8f9Z+PGKCfMWZ7JWT-UA@mail.gmail.com> <1430685362-12270-1-git-send-email-mikachu@gmail.com>
On Sun, May 3, 2015 at 10:36 PM, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> We refused to set the base outside [2,36], but this restriction should
> only apply to integers (where the base is actually the base). For float
> values, the precision can be anything. We also failed to actually enforce
> this limitation in either of these cases, but only printed the error
> message. We now only update the base if it was valid.
Perhaps we should apply some limit to the precision of floats? For example,
typeset -F 100000000 foo; echo $foo
succeeds, and at least in my setup, causes typing at the next
commandline to be very slow, because of multiple calls to
setunderscore(). It doesn't seem to affect zsh -f. This could also be
a case of "don't do that then". :)
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author