Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value

X-seq: zsh-workers 35239
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxx
Subject: Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value
Date: Wed, 20 May 2015 10:23:00 -0700
In-reply-to: <4003127.y1UWooicOC@kdudka.brq.redhat.com>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <1432059854-2109-1-git-send-email-kdudka@redhat.com> <150519161222.ZM25707@torch.brasslantern.com> <4003127.y1UWooicOC@kdudka.brq.redhat.com>

On May 20,  4:43pm, Kamil Dudka wrote:
}
} Good catch!  Then your patch certainly looks as a better choice to me.

It belatedly occurs to me that adding

    if (!value)
	value = "";

would have been a sufficient change.  Oh, well.

-- 
Barton E. Schaefer

Follow-Ups:
- Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value
  - From: Kamil Dudka

References:
- [PATCH] mkenvstr: avoid crash in case NULL is given as value
  - From: Kamil Dudka
- Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value
  - From: Bart Schaefer
- Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value
  - From: Kamil Dudka

Messages sorted by: Reverse Date, Date, Thread, Author