Re: [PATCH] __git_commit_objects_prefer_recent: local ret

[Daniel Hahler <genml+zsh-workers@xxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 21.05.2015 20:05, Bart Schaefer wrote:
> On May 21,  7:30pm, Daniel Hahler wrote:
> }
> } Without this, `ret` will be set to 1 with `git diff --ex<tab>` and
> } result in duplicate entries:
> } 
> } I am not sure if this is the right way to do it.
> 
> Wouldn't it make more sense to put "local ret" in _get_recent_commits ?
> 

I'm not sure - I've thought it was not used there on purpose, for when it gets called
for --fixup and --squash?

  _arguments -w -S -s \
    '(-a --all --interactive -o --only -i --include *)'{-a,--all}'[stage all modified and deleted paths]' \
    '--fixup=[construct a commit message for use with rebase --autosquash]:commit to be amended:__git_recent_commits' \
    '--squash=[construct a commit message for use with rebase --autosquash]:commit to be amended:__git_recent_commits' \

But putting it there appears to work, too.


Regards,
Daniel.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iD8DBQFVXiXyfAK/hT/mPgARAsOXAKD35BaKCpszaRvmQaOygaMa4Pe3TgCgw+PD
ErPUBrNevfJG+46hYtIfx4k=
=zoKe
-----END PGP SIGNATURE-----