Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: ztrftime: Pass everything unhandled to the system strftime()
- X-seq: zsh-workers 35768
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: Peter Stephenson <p.stephenson@xxxxxxxxxxx>
- Subject: Re: PATCH: ztrftime: Pass everything unhandled to the system strftime()
- Date: Fri, 10 Jul 2015 18:31:12 +0000
- Cc: Zsh Hackers' List <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=RpRhYIsdwt2nP7Dm05e3b29mQhQ=; b=0Bh9Fm 9Cqdc0IkWCLONdjIoALnQSDur2gN3wWqdGoFqzO8QvHIMLj9BuSK75tjh65OyAGv r/suywEyuhoGGWPOa6FGsvV9I2OzL1IjuaHaKCjBsRKDNJLYmCRiVxMg00lSJUV9 7cl8/XPeTZgsM1+3U+/FuwDM0UGM1H8P4wvDI=
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=RpRhYIsdwt2nP7Dm05e3b29mQhQ=; b=RJV6G e6iNHPQVmOrGsU2NrGnRSu44vLM1/gBMxeXz1C5Vjk5uUjeHfiV6ao54e1R4kR89 iB41SXNyOf3QXrgLWvjvNTuctVvYf8HmJY/80MU4CBPVp5J2s/ozP69qoFL+5kC4 1psO+dxGW7Vh/raopL11bvO0WMehn6SqfR0uf4=
- In-reply-to: <20150710143708.71ec8178@pwslap01u.europe.root.pri>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20150709094122.17abacc8@pwslap01u.europe.root.pri> <1436435887-28736-1-git-send-email-mikachu@gmail.com> <20150709111756.631dac65@pwslap01u.europe.root.pri> <20150710143708.71ec8178@pwslap01u.europe.root.pri>
Peter Stephenson wrote on Fri, Jul 10, 2015 at 14:37:08 +0100:
> +++ b/Test/C02cond.ztst
> @@ -151,14 +151,11 @@
> cat $unmodified
> touch $newnewnew
> if [[ $OSTYPE == "cygwin" ]]; then
> - print -u$ZTST_fd "Warning: not testing [[ -N file ]] (not supported on Cygwin)"
> - true
> + ZTST_skip="[[ -N file ]] not supported on Cygwin"
This skip mechanism has the unusual property that the remainder of the
test is still run, but its output is discarded.
Perhaps ZTST_skip should be converted to a statement? e.g.,
ZTST_skip "[[ -N file ]] not supported on Cygwin"
where ZTST_skip is defined such that the remainder of the test case
isn't executed.
And for the sake of explicitness, this should be mentioned in B01cd.ztst
along with the other test harness features.
Cheers,
Daniel
Messages sorted by:
Reverse Date,
Date,
Thread,
Author