Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: ztrftime: Pass everything unhandled to the system strftime()



Peter Stephenson wrote on Fri, Jul 10, 2015 at 14:37:08 +0100:
> +++ b/Test/C02cond.ztst
> @@ -151,14 +151,11 @@
>    cat $unmodified
>    touch $newnewnew
>    if [[ $OSTYPE == "cygwin" ]]; then
> -    print -u$ZTST_fd "Warning: not testing [[ -N file ]] (not supported on Cygwin)"
> -    true
> +    ZTST_skip="[[ -N file ]] not supported on Cygwin"

This skip mechanism has the unusual property that the remainder of the
test is still run, but its output is discarded.

Perhaps ZTST_skip should be converted to a statement?  e.g.,
    ZTST_skip "[[ -N file ]] not supported on Cygwin"
where ZTST_skip is defined such that the remainder of the test case
isn't executed.

And for the sake of explicitness, this should be mentioned in B01cd.ztst
along with the other test harness features.

Cheers,

Daniel



Messages sorted by: Reverse Date, Date, Thread, Author