Re: [PATCH 1/1] add ssh option FingerprintHash

[Mikael Magnusson <mikachu@xxxxxxxxx>]

On Wed, Aug 5, 2015 at 10:55 PM, Christian Hesse <list@xxxxxxxx> wrote:
> Mikael Magnusson <mikachu@xxxxxxxxx> on Wed, 2015/08/05 21:38:
>> On Wed, Aug 5, 2015 at 8:41 PM, Christian Hesse <list@xxxxxxxx> wrote:
>> > From: Christian Hesse <mail@xxxxxxxx>
>> >
>> > Signed-off-by: Christian Hesse <mail@xxxxxxxx>
>> > ---
>> >  Completion/Unix/Command/_ssh | 5 +++++
>> >  1 file changed, 5 insertions(+)
>> >
>> > diff --git a/Completion/Unix/Command/_ssh b/Completion/Unix/Command/_ssh
>> > index fb8fe57..b7b7e41 100644
>> > --- a/Completion/Unix/Command/_ssh
>> > +++ b/Completion/Unix/Command/_ssh
>> > @@ -219,6 +219,10 @@ _ssh () {
>> >            _message -e 'escape character (or `none'\'')'
>> >            ret=0
>> >            ;;
>> > +        (#i)fingerprinthash=*)
>> > +          _values 'fingerprint hash algorithm' \
>> > +              md5 ripemd160 sha1 sha256 sha384 sha512 && ret=0
>>
>> Not sure how I missed that one, thanks. My manpage only lists md5 and
>> sha256 as options, is it out of date?
>
> Oh, no... The same here. man ssh_config(5) from OpenSSH 6.9 lists md5 and
> sha256 only.
>
> I looked at the source code to find all possible algorithm. Not sure why...
> Probably because man ssh(1) lists the options, but no possible values.
>
> I've sent a patch to the openssh mailing list [0] to update ssh_config.5.
> Usually some time goes by until you get a response there... Until that
> happens - do we want to match documentation or code?

As long as they options work, we might as well complete them. Thanks
for double checking :).

-- 
Mikael Magnusson