Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] _git-cat-file blob completion fix
- X-seq: zsh-workers 36238
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH] _git-cat-file blob completion fix
- Date: Wed, 19 Aug 2015 04:10:42 +0200
- Cc: zsh workers <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=Q8cjL06DLjvz53dUx9I4YJUdMoT+7n2A74oLMUGMh7g=; b=PvrjDalQL7WuPdCLdD0Yrq1ciXTbmgFg8MuctAJ7UGNsXHTL5HOuMof8TkGTi2AowQ o3h0cEANovkd1K3pHVIf76XRJUMwp7+SAyStShig27Y+5RAu+n1OMCvHFhrva5aRItKe 3+p31biFEZjII4/1/rjmqzcjSy0OvlIi7Dtcv9xMd9ZYpppUWtSuCOg44Z03ra/isbD0 6/0GxWQqVoAimtEScT3q2yEDBEEf3I65T6jhDOrLx47oDFyO01gGe8hRTcCfsMPcDXyl sSMXumM5ucImHhWaXZTu4MWk+ol7xeU30Am/4UX4jZnT52MrMuf6HSuYozk0WalhOr7I NtsA==
- In-reply-to: <20150819020536.GE2005@tarsus.local2>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20150819020536.GE2005@tarsus.local2>
On Wed, Aug 19, 2015 at 4:05 AM, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> 'git cat-file HEAD:<TAB>', when cwd is a subdirectory of a repository,
> completes files within that subdirectory, but should complete files
> relative to the repository root. The attach patch implements that.
>
> Review would be appreciated — I might have missed something while
> reverse-engineering the semantics of everything. (I already checked
> gitrevisions(7) and tested 'git rev-parse HEAD:<TAB>'.)
>
> I didn't make --root-relative a zparseopts option because I didn't want
> to have to name the same as git option it maps to.
You can say HEAD:./foo to specify foo relative to the current
directory. However, this doesn't work in the current completer either
afaict, so it's not a regression to apply this patch :).
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author