Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
lseek() on directories, again
- X-seq: zsh-workers 36566
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: lseek() on directories, again
- Date: Sat, 19 Sep 2015 22:13:56 -0700
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
Here's another case like the one in exec.c (reported in 36350) where we
should not be calling lseek() on a directory opened for reading.
diff --git a/Src/parse.c b/Src/parse.c
index 7c2d202..a26df6f 100644
--- a/Src/parse.c
+++ b/Src/parse.c
@@ -3227,6 +3227,8 @@ build_dump(char *nam, char *dump, char **files, int ali, int map, int flags)
noaliases = ali;
for (hlen = FD_PRELEN, tlen = 0; *files; files++) {
+ struct stat st;
+
if (!strcmp(*files, "-k")) {
flags = (flags & ~(FDHF_KSHLOAD | FDHF_ZSHLOAD)) | FDHF_KSHLOAD;
continue;
@@ -3235,6 +3237,7 @@ build_dump(char *nam, char *dump, char **files, int ali, int map, int flags)
continue;
}
if ((fd = open(*files, O_RDONLY)) < 0 ||
+ fstat(fd, &st) != 0 || !S_ISREG(st.st_mode) ||
(flen = lseek(fd, 0, 2)) == -1) {
if (fd >= 0)
close(fd);
Messages sorted by:
Reverse Date,
Date,
Thread,
Author