Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Non-bug in quotestring()/utils.c

Hello,
when compiling, the following warning is issued:

utils.c:5392:6: warning: expression result unused [-Wunused-value]
            *u++;

The expression is the same as *(u++). Maybe the author used the
"after"-++ to expect that it will be applied after dereference? What
actually happens is that it is the dereference that is applied last.

On the other hand, the code:
        if (inull(*u))
            *u++;

- the "if character 0 then skip it" - looks sensible. As there are no
bugs reported about quoting string, the line should probably be
changed to simple u++. So I entitled the email "non-bug", seeing
nothing harmful happens. What is the quoting "QT_DOLLARS", to do some
tests before applying a patch?

Best regards,
Sebastian Gniazdowski
Messages sorted by: Reverse Date, Date, Thread, Author