Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: Make yank zle params writable
- X-seq: zsh-workers 36708
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: zsh workers <zsh-workers@xxxxxxx>
- Subject: Re: PATCH: Make yank zle params writable
- Date: Wed, 30 Sep 2015 03:15:31 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Yyme8UWP9QNIF7i7+Z8AjO4vvrUel5nZBUrV2bjzQLo=; b=Qol3Z3pWMChkSFk1Zb/TlbakMlNd7QQsRnxf10yJ3CfufJLpRDZK9rMvLT4JYaeCch I9vZlvCohoexOjjStWRMHXfgJSWxc2bmpZiB/g4/+oSiQGgvZavDJAylpJjNb0BK0J5/ 12FRFRVIr62mfMCcjFhQ0bC9q/5WKKqHp57ZpQOIOcuIvYm9OTHtpUNWFv7A0gidZKpX FS5wvyr5hgxZHaBF9zXKD26uCz9vUz5NdPbua5Rueze2FGahQd/6HdHGOuofstrWyVMK IHXaVY6RxUFEsRhvj3eOCKMCosVOFhO1jWjyhpwkJsCBFHc5H0a9UZc4Xu7m4zHxm3th PZvQ==
- In-reply-to: <1443501793-29753-1-git-send-email-mikachu@gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <1443501793-29753-1-git-send-email-mikachu@gmail.com>
On Tue, Sep 29, 2015 at 6:43 AM, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> Since these were added without much discussion, it seems a bit silly to
> add yet another interface (zle -f yank) to set them, so just make them
> writable.
I've thought about this some more, and I'm not sure which route to go,
wrt YANK_ACTIVE. It might be better to implement the zle -f interface
after all, if we find we do want to set other flags. If we had
YANK_ACTIVE writable then, we'd have two different interfaces for
setting different bits of the same variable, which might be even more
silly. I think I shall go the route of implementing zle -f
yank(before/after)/kill (I haven't seen evidence of others being
useful yet), and applying this patch (plus later amendments), apart
from the writable part of YANK_ACTIVE. It seems nobody else has strong
opinions about this, but sorry for going back and forth so much about
it :).
It probably also makes more sense to have a separate thing to set the
flag than to read it, since you're reading what the flag was before
entering this widget, but setting what it will be after it finishes.
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author