Re: WARN_CREATE_GLOBAL and parameters used by the shell

[Peter Stephenson <p.stephenson@xxxxxxxxxxx>]

On Fri, 20 Nov 2015 12:55:38 +0100
Vincent Lefevre <vincent@xxxxxxxxxx> wrote:
> There's a problem with smart-insert-last-word:
> 
> smart-insert-last-word:63: scalar parameter _ilw_lcursor created globally in function
> smart-insert-last-word:76: scalar parameter _ilw_hist created globally in function
> smart-insert-last-word:77: scalar parameter _ilw_count created globally in function
> smart-insert-last-word:122: scalar parameter _ilw_cursor created globally in function
> smart-insert-last-word:125: scalar parameter _ilw_changeno created globally in function
> 

Those are all intentional.

pws

diff --git a/Functions/Zle/smart-insert-last-word b/Functions/Zle/smart-insert-last-word
index 67adea7..cf8715d 100644
--- a/Functions/Zle/smart-insert-last-word
+++ b/Functions/Zle/smart-insert-last-word
@@ -60,7 +60,7 @@ then
     lcursor=$_ilw_lcursor
 else
     NUMERIC=1
-    _ilw_lcursor=$lcursor
+    typeset -g _ilw_lcursor=$lcursor
 fi
 # Handle the up to three arguments of .insert-last-word
 if (( $+1 ))
@@ -73,8 +73,8 @@ then
     (( NUMERIC )) || LBUFFER[lcursor+1,cursor+1]=''
     numeric=$((-(${2:--numeric})))
 fi
-_ilw_hist=$HISTNO
-_ilw_count=$NUMERIC
+typeset -g _ilw_hist=$HISTNO
+typeset -g _ilw_count=$NUMERIC
 
 if [[ -z "$numeric" ]]
 then
@@ -119,7 +119,7 @@ fi
 (( NUMERIC > $#lastcmd )) && return 1
 
 LBUFFER[lcursor+1,cursor+1]=$lastcmd[-NUMERIC]
-_ilw_cursor=$CURSOR
+typeset -g _ilw_cursor=$CURSOR
 
 # This is necessary to update UNDO_CHANGE_NO immediately
-zle split-undo && _ilw_changeno=$UNDO_CHANGE_NO
+zle split-undo && typeset -g _ilw_changeno=$UNDO_CHANGE_NO