Re: zsh 5.1.1-test-1

[Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>]

On Sun, 22 Nov 2015 12:48:36 +0100
"Manuel Presnitz" <mpy@xxxxxxx> wrote:
> I experience problems with this command
>   $ hash -m 'foo'
> which hangs infinitely

Yes, it's infinite; it's a simple missing increment.  (Took a while for
the penny to break out of the non-dropping loop while I scratched my
head over search algorithms...)

I'm wondering, having just looked, whether it's safe to use a variable-size
array for all the hash nodes in the command table when sorting?  That's
using up quite a lot of stack.

pws

diff --git a/Src/builtin.c b/Src/builtin.c
index 01eb5b8..cac4f42 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3712,6 +3712,7 @@ bin_hash(char *name, char **argv, Options ops, UNUSED(int func))
 		zwarnnam(name, "bad pattern : %s", *argv);
 		returnval = 1;
 	    }
+	    argv++;
             continue;
 	}
         if (!(asg = getasg(&argv, NULL))) {