Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
[PATCH 1/3] No functional change: rename local variables.
- X-seq: zsh-workers 37250
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: [PATCH 1/3] No functional change: rename local variables.
- Date: Mon, 30 Nov 2015 03:21:05 +0000
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-type:date:from:message-id :mime-version:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=/eP TW8Yg98YBNmp5zh5uuBRvpq8=; b=dw/Z448GKnHgjzNmD5+k6dkUFaSZbPODIX7 dcGuQaU+0YpvaPTx8YlTHI7xpMNOvWE/Zi6rAygjbL+7+hpQnT5Ytm6kBEtRzAvb cA8vGs3FhYt/389xnqRLouFTMjMF1zCMXwKK6B0TJNYjls9fAHIUNDCS7HryxCwp hc/TaD98=
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=/e PTW8Yg98YBNmp5zh5uuBRvpq8=; b=ebgtPbSfFmeyN4Q91RyesekPirSXlt+U+g Zqcfz9CGAzl2lV4HfKwbtSZollZjQjzGengUx7axip+aOllrw6zwdiSnL1AED0rl hMLa7IrhLIp3sd2hBN8PlTGVWtq3pjS53VWe4Zv9Cl14n/YnnRQEj0vMtFEiCxZR 654y4Bbes=
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
---
Src/params.c | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/Src/params.c b/Src/params.c
index 4600284..ee15271 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -2547,7 +2547,9 @@ setarrvalue(Value v, char **val)
arrhashsetfn(v->pm, val, 1);
} else {
char **old, **new, **p, **q, **r;
- int n, ll, i;
+ int pre_assignment_length;
+ int post_assignment_length;
+ int i;
if ((PM_TYPE(v->pm->node.flags) == PM_HASHED)) {
freearray(val);
@@ -2561,31 +2563,32 @@ setarrvalue(Value v, char **val)
v->end--;
}
q = old = v->pm->gsu.a->getfn(v->pm);
- n = arrlen(old);
+ pre_assignment_length = arrlen(old);
if (v->start < 0) {
- v->start += n;
+ v->start += pre_assignment_length;
if (v->start < 0)
v->start = 0;
}
if (v->end < 0) {
- v->end += n + 1;
+ v->end += pre_assignment_length + 1;
if (v->end < 0)
v->end = 0;
}
if (v->end < v->start)
v->end = v->start;
- ll = v->start + arrlen(val);
- if (v->end <= n)
- ll += n - v->end + 1;
+ post_assignment_length = v->start + arrlen(val);
+ if (v->end <= pre_assignment_length)
+ post_assignment_length += pre_assignment_length - v->end + 1;
- p = new = (char **) zshcalloc(sizeof(char *) * (ll + 1));
+ p = new = (char **) zshcalloc(sizeof(char *)
+ * (post_assignment_length + 1));
for (i = 0; i < v->start; i++)
- *p++ = i < n ? ztrdup(*q++) : ztrdup("");
+ *p++ = i < pre_assignment_length ? ztrdup(*q++) : ztrdup("");
for (r = val; *r;)
*p++ = ztrdup(*r++);
- if (v->end < n)
+ if (v->end < pre_assignment_length)
for (q = old + v->end; *q;)
*p++ = ztrdup(*q++);
*p = NULL;
--
2.1.4
Messages sorted by:
Reverse Date,
Date,
Thread,
Author