Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: Add zle-line-pre-redraw hook for highlighting

X-seq: zsh-workers 37416
From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
Subject: Re: PATCH: Add zle-line-pre-redraw hook for highlighting
Date: Sat, 19 Dec 2015 09:49:13 +0000
Cc: Mikael Magnusson <mikachu@xxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=basYdgPLPRfwo9pjLKD2fYkAcS0=; b=JBtdEv IidJFxGZW0dZ87qqDRb3lBTyPSjqjl1HPbSVX0x9XNQWa9nST2vqEeQacZYAnZ7B nBFUsmoW9rG/4Nv6yH3ugth5ySzOCiQ+ygAteEmo0JvqZ7FHtFUpYxTSrhq8g2hY QzGLJfLpg0ehQDmYaoHIwBVCjj/MVLjhHkjCU=
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=basYdgPLPRfwo9pjLKD2fYkAcS0=; b=Pvars 12TrT3LV2AGTkdxKIraLBB0NDgWdMAQv41snZQ82oQofNTwvV0w8rZ890ek9GlI7 Q0C7EWfry9lLn+xXq2gWH/E9HVjQ/GFJJneeRyXIcHJ3wujZbZUcSMnGUeTMB1EG zlxiaVRCX6Y/t9RKANTv2nZ7cwFldMRB0SqO7k=
In-reply-to: <CAH+w=7btpFWXkgHFjHwMFWZcrVu-ap5+=PAkeidze8NJsz+SoA@mail.gmail.com>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <CAHYJk3QvRnYxLMb8XsoWB1hU92Qti_fEKt1JgxkyDARrhf1g7g@mail.gmail.com> <1450245754-2760-1-git-send-email-mikachu@gmail.com> <CAH+w=7btpFWXkgHFjHwMFWZcrVu-ap5+=PAkeidze8NJsz+SoA@mail.gmail.com>

Bart Schaefer wrote on Wed, Dec 16, 2015 at 00:05:01 -0800:
> On Dec 15, 2015 10:27 PM, "Mikael Magnusson" <mikachu@xxxxxxxxx> wrote:
> > I haven't received any complaints about 36650 from testers, so I'll go ahead
> > and push this.

Hooray!

This should fix between 2 and 5 z-sy-h issues:
https://github.com/zsh-users/zsh-syntax-highlighting/issues/245

> > If anyone has a better idea for the name of the hook, there
> > should be plenty of time to bikeshed before the next release :).
> 
> How about just "...-pre-draw" instead of "pre-re"?

"pre-redraw" seems fine to me: the double "re" is not redundant, and
"redraw" is the usual term for "the action performed by ^L".

Cheers,

Daniel

References:
- Highlight hook
  - From: Mikael Magnusson
- PATCH: Add zle-line-pre-redraw hook for highlighting
  - From: Mikael Magnusson
- Re: PATCH: Add zle-line-pre-redraw hook for highlighting
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author