Re: C02cond.ztst segfaults (was: Re: Strange test suite behaviour since zsh 5.2-dev-1: C02cond.ztst no more reports its finishing)

[Axel Beckert <abe@xxxxxxxxxx>]

Hi,

Axel Beckert wrote:
> On Sun, Jan 31, 2016 at 03:12:51PM -0800, Bart Schaefer wrote:
> > On Feb 1, 12:03am, Axel Beckert wrote:
> > } Program terminated with signal SIGSEGV, Segmentation fault.
> > } #1  0x000055e7dc4af8f4 in is_cond_binary_op (str=0x7f05376fe238 "non-empty-string") at ../../Src/text.c:63
> > 
> > Try this:
> > 
> > diff --git a/Src/text.c b/Src/text.c
> > index 04acd2a..cf6d3eb 100644
> > --- a/Src/text.c
> > +++ b/Src/text.c
> > @@ -47,7 +47,7 @@ int text_expand_tabs;
> >   */
> >  static const char *cond_binary_ops[] = {
> >      "=", "!=", "<", ">", "-nt", "-ot", "-ef", "-eq",
> > -    "-ne", "-lt", "-gt", "-le", "-ge", "=~"
> > +    "-ne", "-lt", "-gt", "-le", "-ge", "=~", NULL
> >  };
> >  
> >  static char *tptr, *tbuf, *tlim, *tpending;
> 
> Thanks! That fixed at least my local segfault when compiling with
> -fPIE. Will now push that patch to our Jenkins. Hopefully this also
> fixes the 32-bit C02cond.ztst issues, at least the symptoms are the
> same.

It did. Thanks again, Bart!

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@xxxxxxxxxx>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE