Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH 3/4] _git: log: ignore numeric options
- X-seq: zsh-workers 38164
- From: m0viefreak <m0viefreak.cm@xxxxxxxxxxxxxx>
- To: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 3/4] _git: log: ignore numeric options
- Date: Wed, 16 Mar 2016 21:43:37 +0100
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=CkyunaK+YZ4ehGQUwxsCEJgn3ItbfI8AjgDkTsw0MP0=; b=UjzOlaLtNfqHvusTIeN7N5DPA/20RzvmfoNNzSfzhzJlI5uZBSTo+uTcLW+i8GjlSh hdNvPhXh0w92g7ptggB4cNNM1avnHBPPH3vjThKexMNY0GAtNEjogbqNq7F9bKal97J3 qMdmyEfTnrIwUkLq8/hbuyt4fmP73Joma/LHdVk7d1eThivrX2XfC7NzVgXtfVDVTQ68 9T/Wb5818NgSf27Emx0AL74Lg/rP/ONmGwZqDQpEOwkAswBq0+husQgf0JSkPRhddxqC xAd5A8B+yRmnr4L/uEAkooh6IRlB+ZIJZlG82dJQoCn2L6nFCnxKEck53Tui9jQoMMOC 1DUg==
- In-reply-to: <20160315000837.GA29956@tarsus.local2>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <1457906520-2612-1-git-send-email-m0viefreak.cm@googlemail.com> <1457906520-2612-4-git-send-email-m0viefreak.cm@googlemail.com> <20160315000837.GA29956@tarsus.local2>
On 15.03.2016 01:08, Daniel Shahaf wrote:
> I couldn't reproduce that: with current master, none of «git log
> -<TAB>», «git log -9<TAB>», or «git log -9 -<TAB>» go through the
> 'first-commit-ranges-or-files' code branch.
>
> m0viefreak, if there is still a (possibly latent) bug in current master,
> could you please explain/show it?
git log -9 <TAB>
should go through the 'first-commit-ranges-or-files' branch because at
that position the first argument is expected.
Without this patch it goes through the 'commit-ranges-or-files' branch,
because '-9' is wrongly treated as the first non-option argument:
functions -T _git-log; git log -9 <TAB>
without this patch:
+_git-log:16> case commit-ranges-or-files (first-commit-ranges-or-files)
+_git-log:16> case commit-ranges-or-files (commit-ranges-or-files)
+_git-log:28> [[ -z '' ]]
+_git-log:29> __git_commit_ranges
+_git-log:29> ret=0
+_git-log:35> __git_is_committish_range -9
+_git-log:37> __git_is_committish -9
+_git-log:40> __git_tree_files . HEAD
+_git-log:40> ret=0
+_git-log:45> return ret
with this patch:
+_git-log:16> case first-commit-ranges-or-files (first-commit-ranges-or-files)
+_git-log:18> [[ -n '' ]]
+_git-log:21> _alternative commit-ranges::__git_commit_ranges 'cached-files::__git_tree_files ${PREFIX:-.} HEAD'
+_git-log:23> ret=0
+_git-log:45> return ret
This patch makes _arguments ignore any words of the form '-[0-9]#' to
work around that.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author