Re: [PATCH] allopt() and question

[Thilo Six <zsh@xxxxxxx>]

Hello

>>> % builtin set -o | command grep -E '(\<monitor\>|\<zle\>)'
>>> monitor off
>>> zle off
>>
>> This will start separate process for the first thing in pipeline. The
>> last thing is run in current shell. Which is cool for me, 
> 
> Now that you mention it i can remeber to have read about that. Back then a bash
> user where this is not the default. But iirc they have nowadays a option for it.
> Still to me this seem not to be the whole story.
> For one it only occurs with only some specific shell options and second:
> 
> % foo="$(builtin set -o)"
> % echo $foo | command grep -E '(\<monitor\>|\<zle\>)'
> monitor               off
> zle                   off
> % allopt '(\<monitor\>|\<zle\>)'
> monitor               on
> zle                   on
> 
> Or am i missing s.th.?

i have been working on making the patch better. During that i noticed
this does work as expected:
    for i in ${OPT_NAMES_ALL} ; do OPT_ALL+=($i ${options[$i]}) ; done

This does not:
    for i in ${OPT_NAMES_ALL} ; do OPT_ALL+=($i ${options[$i]}) ; done | while

So it seems as i allready thought that Zsh is reseting some options when inside
a pipe. Same for 'set -o' and 'setopt' by the way.

Now to the "improvements"-
Meantime i have learned about v and k modifiers which saves a for loop.

The main point i did not like about the previous version was code duplication.
The original version of allopt used a function for that.

There are two reasons why i did went the other approach first:
1)
I often fire up a new instance enter some chars and hit <Tab> just to check if
that command exists already. Mostly in cases where i write new functions to
prevent name clashes.
Function definitions inside functions are hidden from the shell unless the outer
function is run once. So this potentially calls then for name clashes.

2)
One thing i haven't verified yet is, if a local PARAMATER in the outer function
is avail to the inner defined function.
If so that would be nice. If Not that would have reduced code duplication at the
end and doubled it at start of the function where the PARAMETERs are defined.

Actually there is way to have both, or better yet one without the other.
See attached.


All of this is TTBOMK @ $EPOCHSECONDS.


Final: I attach a plain autoload func file. If you are actually interested i
produce a proper patch.


OT:

One last thing i want to say if i am allowed:
When one searches around the web after zsh one of the top most named things is:
what one can put into his PS1.
That i nice actually.
Also modifiers are great.

But if i have to name my top most Zsh killer feature it would be this tiny
little sentence which is easly overlooked:

      One commonly encountered difference is that variables substituted  onto
      the  command line are not split into words.

White-listing of splitting is so much more naturally then black-listing it.

THANK you so much for making a sensible shell!


And now i shut up. ;)

Nice day everyone!



kind regards,

     Thilo








# vim: ts=8:sw=4:sts=4:et:ft=zsh:
# kate: byte-order-marker false; dynamic-word-wrap false; indent-mode normal; indent-pasted-text true; indent-width 4; keep-extra-spaces false; newline-at-eof true; remove-trailing-spaces all; replace-tabs true; replace-tabs-save true; show-tabs true; smart-home true; syntax Zsh; tab-width 8; word-wrap false;
#-----------------------------------------------------------------------
#
# This function lists options with the no's in front removed for
# improved comprehension, i.e. `norcs off' becomes `rcs on'.
# The format is otherwise like that with `kshoptionprint' set,
# i.e. you can see all options whether on or off.
# It can take a list of option names or parts thereof to search for
# via egrep.
#
# Written by Sweth Chandramouli with hacks by Bart Schaefer.
# updated by Thilo Six

# allopt() {
    local    OPT_NAME OPT_VALUE LENGTH i
    local -a OPT_NAMES_ALL
    local -A OPT_ALL
    OPT_NAMES_ALL=(${(ok@)options})

    # http://zsh.sourceforge.net/Guide/zshguide05.html
    LENGTH=$(( ${#${OPT_NAMES_ALL[(r)${(l.${#${(O@)OPT_NAMES_ALL//?/X}[1]}..?.)}]}} + 1 ))

    ### XXX note:
    #   make a backup of ${(@)options}
    #   this needs to be done because otherwise
    #   the listing is inaccurat e.g. 'monitor' and 'zle' are always off
    #   the set builtin treats them special within a pipe. compare this:
    #   % builtin set -o
    #       with
    #   % builtin set -o | command grep -E '(\<monitor\>|\<zle\>)'
    #
    OPT_ALL=(${(kv@)options})

    {
        for i in ${OPT_NAMES_ALL} ; do echo "${i} ${OPT_ALL[$i]}" ; done | while read OPT_NAME OPT_VALUE ; do
            if [[ ${OPT_NAME#no} != ${OPT_NAME} ]] ; then
                OPT_VALUE=${(L)${${OPT_VALUE:s/on/OFF}:s/off/on}}
                OPT_NAME=${OPT_NAME#no}
            fi
            echo "${(r:${LENGTH}:)OPT_NAME} ${OPT_VALUE}"
        done
    } | {
        if [[ -n ${*} ]] ; then
            egrep ${(j.|.)${${${(L)@}#no}//[-_]/}}
        else
            cat
        fi
    }
# }