Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH v2 2/3] Fix the ':A' word modifier on paths with '..' components.
- X-seq: zsh-workers 38759
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: Mikael Magnusson <mikachu@xxxxxxxxx>
- Subject: Re: [PATCH v2 2/3] Fix the ':A' word modifier on paths with '..' components.
- Date: Sat, 25 Jun 2016 16:28:07 +0000
- Cc: zsh workers <zsh-workers@xxxxxxx>
- In-reply-to: <CAHYJk3QPM+wKmzoT5jhPD90e=kYpdT0Yf2hNXcZd9woUSov+Mg@mail.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20160613085218.GA9572@tarsus.local2> <1466474004-4669-1-git-send-email-danielsh@tarsus.local2> <1466474004-4669-2-git-send-email-danielsh@tarsus.local2> <CAHYJk3QPM+wKmzoT5jhPD90e=kYpdT0Yf2hNXcZd9woUSov+Mg@mail.gmail.com>
Mikael Magnusson wrote on Tue, Jun 21, 2016 at 05:08:16 +0200:
> On Tue, Jun 21, 2016 at 3:53 AM, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> > The fix is to stop calling chabspath() at the top of chrealpath().
> >
> > Preserve the old behaviour when CHASE_DOTS is set.
>
> I think this is backwards, cd symlink/.. gets you to the current dir
> if chasedots is unset, and to wherever symlink points' parent
> directory when it is set.
True.
However, I don't want to just flip the condition (change "if isset()" to
"if unset()") since I think the new behaviour (resolving symlinks before
'..' components) should be the default for :A.
So how about adding a new option and having chrealpath() use the new
behaviour if the new option is at its default value, and the old
(':a'-ish) behaviour otherwise?
Messages sorted by:
Reverse Date,
Date,
Thread,
Author