Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] Add completion for cpupower command
- X-seq: zsh-workers 38987
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- Subject: Re: [PATCH] Add completion for cpupower command
- Date: Mon, 1 Aug 2016 21:41:09 +0000
- Cc: Andy Spencer <andy@xxxxxxxxxx>, zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=b0TvRiYm/vG50u9LkDP9N4QBIKg=; b=14n8sH bXZ/8wwxKbBkkpBJZPwt/5SPDx9mgZtAffjtpJdogQPvoFsP2WkoVFbmCjImyqoL 1NHVdFugB33jI/lK1AuH3RtaQ8/AATPnd/BEbZmrW0UoWaad58s9AA3VoWnZh6gD hzRGWcz69VBXUMnEVtNGMrFJmRuu7NmpDDY08=
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=b0TvRiYm/vG50u9LkDP9N4QBIKg=; b=VoZDg +duaqdcCFO0N/JEkWrDjZYN19X0Jg+MLG4dDdbFWFi5fJazaIUlVnrdWHQAcBvl6 S2KnOL85qUznqyOMb4pBMEmXEqCxAh9eOhRenBGkU1FrmCq+ZZuPVaszWzGAI6bf X4lH064TLQuSb4qW4QahCTVGY6JZJGC94/K5qE=
- In-reply-to: <16722.1470082775@hydra.kiddle.eu>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20160731110516.GA20521@pileus.org> <16722.1470082775@hydra.kiddle.eu>
Oliver Kiddle wrote on Mon, Aug 01, 2016 at 22:19:35 +0200:
> Andy Spencer wrote:
> > + '(-f --freq)'{-f,--freq}'[new frequency for userspace governor]:freq->freq'
>
> There's a colon missing on that line.
Should it be {-f+,--freq=}? That is, can the argument be in the same
word as the option?
The part after the first colon is in this function abbreviated ("freq",
"secs", etc); don't we usually prefer full noun phrases ("frequency",
"interval (seconds)", etc)?
Oliver's review addresses all the other points I noticed (and a few that
I didn't).
Cheers,
Daniel
Messages sorted by:
Reverse Date,
Date,
Thread,
Author