Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: Zsh Completion - Bug report
- X-seq: zsh-workers 39068
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: Stefano Balzan <stefano.balzan@xxxxxxxxx>
- Subject: Re: Zsh Completion - Bug report
- Date: Fri, 19 Aug 2016 15:58:29 +0000
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=wLRmLO8tplYLp8+M 5oMlO6Qcx3s=; b=iJV/D4I4bzXcYWXjy+W8yOyCucAa9veEa6yKCEBvmBSZtcAQ wn9bRa24spmoa68ApQOzG7q56F8EheYpRIHV5t7PfT5rOSuFWCI2F/DjOQpiMBGJ TZy2ZM47h+lmn7n1ld5aelGOlwtQkpAg/N5CmvaVjjrwD3n6v/NM4BYJl7c=
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=wLRmLO8tplYLp8+ M5oMlO6Qcx3s=; b=rLErMvfaRmPg991N/sSFV/XoRmnEQP1p4vxoA9jbziOqvP0 3ST+FQeLG/cxmw5sbgB/U5S7m+/xmNBRylIFweL4DB7MFcj3te6YGKMNcxHkZXIX roCqxoNs4cG/1hNb3mpjvCptuNl6j3hzyeaUTYrgrbYHj0DLN8j/H2ZMLEMQ=
- In-reply-to: <CAEimH9D2Nu1b7s2EHWkBM1EAtJyREHMMjcFod_1OCXsJD=ke6g@mail.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CAEimH9D2Nu1b7s2EHWkBM1EAtJyREHMMjcFod_1OCXsJD=ke6g@mail.gmail.com>
Stefano Balzan wrote on Fri, Aug 19, 2016 at 12:10:02 +0200:
> Hello,
> I've probably found a bug in the 'ip neigh' commands set.
> Zsh completion sugguests using 'lladr' instead of 'lladdr' resulting in the
> following error:
> "Error: either "to" is duplicate, or "lladr" is a garbage."
>
> It took me a while to find the subtle difference, since I rarely use the ip
> tools and it could be misleading for several users.
Thanks:
diff --git Completion/Unix/Command/_ip Completion/Unix/Command/_ip
index 1e39491..9833cdb 100644
--- Completion/Unix/Command/_ip
+++ Completion/Unix/Command/_ip
@@ -285,7 +285,7 @@ local -a neigh_add_cmds
_regex_words neigh-add-commands "neighbour add command" \
't*o:add new neighbour IP address:$subcmd_ipaddr' \
'dev:specify network device:$subcmd_dev' \
- 'l*ladr:specify link layer (MAC) address or null:$subcmd_lladdr' \
+ 'l*ladrr:specify link layer (MAC) address or null:$subcmd_lladdr' \
'n*ud:specify neighbour unreachability detection state:$subcmd_nud'
# to-address without keyword can appear first
neigh_add_cmds=( "(" $subcmd_ipaddr "|" ")" "$reply[@]" "#")
One other issue: the man page synopsis is
.
ip neigh { add | del | change | replace } { ADDR [ lladdr LLADDR ] … } …
.
but the word "lladdrr" is completed at argv[3], not at argv[4] as I'd
expect from the synopsis. I'm not familiar with ip(8) so I'll leave
investigating this to someone else...
Cheers,
Daniel
Messages sorted by:
Reverse Date,
Date,
Thread,
Author