Re: PATCH: minor git completion tweaks

[Mikael Magnusson <mikachu@xxxxxxxxx>]

On Fri, Aug 19, 2016 at 6:49 PM, Oliver Kiddle <okiddle@xxxxxxxxxxx> wrote:
> This is just a few minor tweaks that were suggested off-list following
> last week's patch.
>
> Oliver
>
> diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
> index ac4c90e..f4011aa 100644
> --- a/Completion/Unix/Command/_git
> +++ b/Completion/Unix/Command/_git
> @@ -249,11 +249,7 @@ _git-bisect () {
>                ;;
>            esac
>            ;;
> -        (${(j.|.)~good})
> -          _arguments \
> -            ': :__git_commits' && ret=0
> -          ;;
> -        (${(j.|.)~good}|skip)
> +        (${(j.|.)~bad}|${(j.|.)~good}|skip)
>            # TODO: skip can take revlists.
>            _arguments \
>              '*: :__git_commits' && ret=0

Could this be (~j.|.) instead? Just in case someone defines good/bad
terms with a pattern character in them :). Also, should it be "git
bisect terms" above this, rather than just "git terms"? I only have
the former, on git 2.8.xyz.

-- 
Mikael Magnusson