Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: Off-by-one with select-*-shell-word text object?
- X-seq: zsh-workers 39373
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: Off-by-one with select-*-shell-word text object?
- Date: Sat, 17 Sep 2016 07:42:59 +0000
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=FNKF9SRhZOLHWK61649XYU4/A7g=; b=MCLfRF rg/nwR3CQXalzpAj6O2y5Uliqhyns3f/RA9/Z9VRwdsLB53nlIR6YNXCR6ONfIdz 6Ja+QxqJYNB0QGbmtYBD7k0W2nqAVLJWMXoSQyO4DIrazmwj5rlNwiHAE4PCGyZ6 2THqQ2UDNaeHCSEV7FQ44Ma8uuJPnBvP2bbhg=
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=FNKF9SRhZOLHWK61649XYU4/A7g=; b=mz+RU YfaSAJCYrNzqqU4bL5odWHae5hU9dHQTC02uVky3jYpDVzesTrmOPpHqhAl7Mfjw WI7XC/DjFiDn8Jt4WF8xSGr2T2CgDUO2dgeebZa95R8Xl9SQ+/lyDWfLyw/25vh7 ko3umd9peFO739KrnKmhhX+Uty44v5K6FN6qw8=
- In-reply-to: <160916200205.ZM27241@torch.brasslantern.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <160916102137.ZM11290@torch.brasslantern.com> <76020.1474058827@hydra.kiddle.eu> <160916142248.ZM26196@torch.brasslantern.com> <10734.1474068633@hydra.kiddle.eu> <160916200205.ZM27241@torch.brasslantern.com>
Bart Schaefer wrote on Fri, Sep 16, 2016 at 20:02:05 -0700:
> On Sep 17, 1:30am, Oliver Kiddle wrote:
> } run-help, which-command and zap-to-char suffer from the same
> } issue as the text object widgets: they use bindk to select their
> } behaviour.
> }
> } So any thoughts on this solution?
>
> I'd probably write it as an assignment of setbindk rather than put the
> whole expression in the execzlefunc argument, but otherwise this seems
> sensible on the face of it.
I think it would be cleaner to invent a new bitmask flag and set it on
the affected widgets (select-*-word, run-help, etc) than to overload
WIDGET_INT for this purpose.
Whether a widget is implemented in C or in shell has no bearing on
whether it assumes that $WIDGET points to itself.
Cheers,
Daniel
Messages sorted by:
Reverse Date,
Date,
Thread,
Author