Re: zsh make(1) completion on FreeBSD

[Guilherme Salazar <gmesalazar@xxxxxxxxx>]

By the way, completely unrelated question: I noticed some
inconsistencies in the use of tabs/spaces for indentation; are there
conventions for that in the project? If so, are patches fixing it
welcome?

On Tue, Oct 11, 2016 at 10:14 PM, Guilherme Salazar
<gmesalazar@xxxxxxxxx> wrote:
>> That's precisely what the _pick_variant call at the top of the function
>> does, so you can just test $is_gnu instead.  Note that the enclosing if
>> already inspects that variable.
>
> $is_gnu will still give unix (on FreeBSD) in case `which make` is just
> a symlink to /usr/local/bin/gmake.
>
>> In current master (before your patch), the 'call-command' style is
>> consulted only for GNU make but not for FreeBSD.  Do you know if that's
>> intentional, perhaps (going by the style's docs) because the GNU make
>> invocation has side-effects while the BSD make invocation has none?
>
> I'd expect the -n option to avoid side effects. Perhaps the reason is
> that the BSD make infrastructure is a lot different than GNU's and a
> single Makefile may not carry enough information by itself to generate
> good completion?