Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] zle: Call zle-line-pre-redraw after inserting a completion result



On Sun, 16 Oct 2016 15:13:54 +0000
Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> m0viefreak wrote on Sat, Oct 08, 2016 at 19:30:16 +0200:
> > This patch originated from a zsh-synatx-highlighting issue:
> > https://github.com/zsh-users/zsh-syntax-highlighting/issues/375
> > 
> > I think redrawhook() should be called at the end of do_single()
> > to make sure that zle-line-pre-redraw is run when cycling the results of
> > a menu completion.
> 
> Any thoughts on the patch?  With my z-sy-h hat, I confirm it behaves as
> promised (applies highlighting whilst tabbing through menu completion),
> but with my zsh hat, I am not familiar with zle enough to review this
> patch.

I can't see anything obviously wrong with it.

pws



Messages sorted by: Reverse Date, Date, Thread, Author