Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing

X-seq: zsh-workers 39790
From: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>
To: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing
Date: Mon, 31 Oct 2016 10:04:03 +0100
Cc: zsh-workers@xxxxxxx
In-reply-to: <20161030203314.GA4276@fujitsu.shahaf.local2> (Daniel Shahaf's message of "Sun, 30 Oct 2016 20:33:14 +0000")
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <20161030024723.62832-1-john.reed.riley@gmail.com> <87y416drcq.fsf@ft.bewatermyfriend.org> <20161030155530.GC12137@fujitsu.shahaf.local2> <20161030170534.GA17437@fujitsu.shahaf.local2> <161030112832.ZM14753@torch.brasslantern.com> <20161030203314.GA4276@fujitsu.shahaf.local2>

Hi,

Daniel Shahaf wrote:
> -            && ( VCS_INFO_check_com hexdump ) && [[ -r ${dirstatefile} ]] ; then
> +            && VCS_INFO_hexdump ${dirstatefile} 20 ; then
>          # Calling hexdump is (much) faster than hg but doesn't get the local rev

While we're at it, that comment should probably be adjusted as well,
since we don't really *call* hexdump any more.


Regards, Frank

Follow-Ups:
- Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing
  - From: Daniel Shahaf

References:
- [PATCH] Fix hexdump command used for mercurial dirstate parsing
  - From: Reed Riley
- Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing
  - From: Frank Terbeck
- Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing
  - From: Daniel Shahaf
- Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing
  - From: Daniel Shahaf
- Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing
  - From: Bart Schaefer
- Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing
  - From: Daniel Shahaf

Messages sorted by: Reverse Date, Date, Thread, Author