Re: [PATCH} define _GNU_SOURCE on Cygwin

["Jun T." <takimoto-j@xxxxxxxxxxxxxxxxx>]

On 2016/10/31, at 15:15, Peter A. Castro <doctor@xxxxxxxxxxxx> wrote:

> I built with Cygwin 1.7.35

Thanks.

> With the proposed patch from Jun, zsh compiles, links and runs the check tests "adequately".

Did you get any "new" warnings when building with the patch?
(new = no warning without the patch)

> I say "adequately" because there were 2 test failures, 5 skipped and 40 successful.

Do the same 2 tests fail if you do not apply the patch?

> As a result, I only applied the change to zsh_system.h, which was successful.

Yes, that is sufficient to test the patch.

Jun