Re: Compiler warning after workers/39825

[Peter Stephenson <p.stephenson@xxxxxxxxxxx>]

On Tue, 8 Nov 2016 15:38:30 +0000
Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:

> Peter Stephenson wrote on Tue, Nov 08, 2016 at 10:07:35 +0000:
> > On Tue, 8 Nov 2016 10:01:49 +0000
> > Peter Stephenson <p.stephenson@xxxxxxxxxxx> wrote:
> > > diff --git a/Src/utils.c b/Src/utils.c
> > > index 733f570..d73110a 100644
> > > --- a/Src/utils.c
> > > +++ b/Src/utils.c
> > > @@ -5341,7 +5341,7 @@ mb_metastrlenend(char *ptr, int width, char *eptr)
> > >  	    inchar = *ptr;
> > >  	ptr++;
> > >  
> > > -	if (complete && (inchar >= 0 && inchar <= 0x7f)) {
> > > +	if (complete && (inchar >= 0 && STOUC(inchar) <= STOUC(0x7f))) {
> >                          ^^^^^^^^^^^^
> > 
> > This is now irrelevant, I'll remove that, too.
> 
> It's relevant on systems where the «char» type is signed.

No, read what the remaining modified test does.  It's not using a signed
value any more.

pws