Re: [PATCH] Optimization of getarrvalue()

[Peter Stephenson <p.stephenson@xxxxxxxxxxx>]

On Mon, 14 Nov 2016 21:32:19 +0900
Jun T. <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
> The original (before a1633e0) behavior is already quite
> confusing to me. For example,
> 
> zsh% nargs "${(@)a[i]}"
> 
> will output 0 only for i=0. On the other hand
> 
> zsh% nargs "${(@)a[i,i]}"
> 
> will output 0 for i=0 and 2.
> If I replace
>    arrlen_lt(s, v->start) by arrlen_le(s, v->start)
> (which may look reasonable since the array s[] is 0-based)
> then nargs "${(@)a[i,i]}" will output 0 only for i=0.
> But then "make check" fails in two tests (D04parameter and
> Y01completion).

If we can agree your patch is OK as far as it goes I'll have a look and
see if I can understand those failures with that additional change.

pws