Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks
- X-seq: zsh-workers 40301
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: m0viefreak <m0viefreak.cm@xxxxxxxxxxxxxx>, zsh-workers@xxxxxxx
- Subject: Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks
- Date: Fri, 6 Jan 2017 09:35:06 -0800
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=GMySgluI8SNxicE0F5msXCPCSDK4EZCiUUYs6e0zj0o=; b=o5C5nM3zC4HXYdV5NWBOiEO6+vRs40SIrRZKGn+iO7pZtulBLhk8i6qIzk1FWGfXeV xOSUuqA2Xv9JS+YMPbn3paE6SK5qguFkzlsSW0D2ff8G4M3+JQ/oIfRyOlQzGHwupKrm Q5zEkvVZF1wYPto9LwWbkg/zoxnBE6f/Q5aLYusoNTpDnR9egh1Fid29cm1Hj1jmhyfY R4ZnB4Qah0YYPzMXhmSfdB1Hn6PKugE9bmvMTWxPSf/3VTd93O5PTxoTAVHvGX/DoGdc zWW73dySjGeVKu7POubQqcOVX+XIF7bksahgZo+UFEOZep7M+K/jeI9fwWuPe+rAc2M7 Nu9A==
- In-reply-to: <20170106172541.GA14113@fujitsu.shahaf.local2>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20170106172541.GA14113@fujitsu.shahaf.local2>
On Jan 6, 5:25pm, m0viefreak wrote:
}
} Using PAT_STATIC, any of the functions called in the hook that make
} use of patterns, implicitly change the pattern we use in the
} isearch loop. In the best case this results in pattern-not-found,
} in the worst case we get a dump.
Thanks for catching this. I expect we're going to be findind this
kind of thing elsewhere, now that we have so many hook points -- lots
of code that was written expecting it would never be re-entered is
potentially going to be invoked from hooks, possibly even from hooks
within hooks.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author