Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks

[Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>]

On Sat, 28 Jan 2017 11:39:02 -0800 (PST)
Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> On Sat, 28 Jan 2017, Bart Schaefer wrote:
> 
> > ... back to deciding whether each individual use of PAT_STATIC is safe
> > WRT signals and hooks.
> 
> Crimony, it looks like pretty much all of compctl.c is signal-UNsafe.
> 
> All the functions are static[*] except for the zmodload entry points.
> Would it be asking for trouble to wrap all the builtin and widget
> implementations of compctl in queue_signals()/unqueue_signals()?

Well, I think the definitive answer is probably the usual "who knows
what anyone's doing with zsh features?"

But my gut feel is compctl only ever got to the point that it was doing
simple local stuff that finished quickly, and we're morally entitled to
assume that anything that isn't like that is using compsys.  So I'd be
inclined to try what you suggest and just make sure a few simple builtin
completions with compctl work.

pws