Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: workers/40626 (commit 6c476c22) causes multiple test failures

On Sunday, February 26, 2017 8:42 PM, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:

> I suspect this is what comes of some attempt to optimize assignments.

It's impossible, hashes weren't optimized. BTW options+=( ), etc. still segfault. Added:

fprintf( stderr, "Pointer of old: %p, pointer of new: %p\n", pm->u.hash, ht );
fflush( stderr );

to setpmoptions(). Shows nicely what you've described in comment in code, don't know how to obtain the same pointer of which you mention, but you can revert to 5.1.1, apply above fprintf, and see it will be still the same. Any problem is impossible because hashes weren't optimized, and optimizations are guarded by: v->pm->gsu.a->setfn == arrsetfn.

-- 

Sebastian Gniazdowski
psprint@xxxxxxxxx
Messages sorted by: Reverse Date, Date, Thread, Author