Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] 2 modules, zsh/db, zsh/gdbm, bug-fixes

On Jun 22, 11:04am, Sebastian Gniazdowski wrote:
}
} 1. New module `zsh/db` that provides good architecture, via
} `*_main_entry` functions in client modules (zsh/db/gdbm in this
} patch).

Nit-pick: This does not include "the following two paragraphs" in any of
the licensing comments that refer to them, so technically it doesn't
pass the license requirements for borrowing from db_gdbm.c.

We might want to update a few of the error strings to make phrasing
and capitalization more similar to others in the shell, but there's
only minimal consistency there anyway so probably not urgent.

Given the bug-fixes in zsh/db/gdbm, this seems worth accepting if the
license comments are fixed.  Other opinions?
Messages sorted by: Reverse Date, Date, Thread, Author