Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] Completion/Unix/Command/_make: whitespace/indent fixes
- X-seq: zsh-workers 41362
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: [PATCH] Completion/Unix/Command/_make: whitespace/indent fixes
- Date: Sun, 25 Jun 2017 13:54:30 -0700
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=twqcuBpVkaZo5SpLCLlr95e8YWMFWd7/zJ1zYyWA/uM=; b=OZ/QV41rlpMXws4f74C++vSHGfJyablb3s6o/I9M99DId0nOHjovTVJ+g9i8v4/GsT tMjeELFr7Bi9eWbJTrpXxNC5Cd3chdjNRCqQrWjvzGm2SdlTZ8qv5aEFpcTtoXhFrTN8 mgTuQaC+y42WZOshlXF/nZMU59mXiG3/ZmAvfZ9PpAPdS+gUEAsixpqS+1loLtBIVnRo 81YmqLpNHmZmntMzisTztTv6U5sYHy2QqGWJdToRQZetY7nyY5a2hbmJzzEBEm/pUx6d PGMlP6fDVgbaPDmGU8MOatQU4xUdfrkRJZmpReWBoadIka+NydEOI3QXas/weLspk1Gi RyeQ==
- In-reply-to: <20170624202834.8182-1-genml+zsh-workers@thequod.de>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20170624202834.8182-1-genml+zsh-workers@thequod.de>
On Jun 24, 10:28pm, Daniel Hahler wrote:
} Subject: [PATCH] Completion/Unix/Command/_make: whitespace/indent fixes
Is this in preparation for some actual functionality change that would
otherwise be conflated with the whitespace changes?
Some of this, for example --
} - while read input
} - do
} + while read input; do
-- and --
} - for (( index=0; index < $#@; index++ ))
} - do
} + for (( index=0; index < $#@; index++ )); do
} if [[ $@[index] == -C ]]
} then
} file=${~@[index+1]} 2>/dev/null
-- seems unnecesary, especially give that you did NOT change any of the
if-newline-then-newline into if-semicolon-then-newline.
Aside from that, it does look better with the deeper case-body indent.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author