Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Completion/Unix/Command/_make: whitespace/indent fixes



On Jun 24, 10:28pm, Daniel Hahler wrote:
} Subject: [PATCH] Completion/Unix/Command/_make: whitespace/indent fixes

Is this in preparation for some actual functionality change that would
otherwise be conflated with the whitespace changes?

Some of this, for example --

} -  while read input
} -  do
} +  while read input; do

-- and --

} -  for (( index=0; index < $#@; index++ ))
} -  do
} +  for (( index=0; index < $#@; index++ )); do
}      if [[ $@[index] == -C ]]
}      then
}        file=${~@[index+1]} 2>/dev/null

-- seems unnecesary, especially give that you did NOT change any of the
if-newline-then-newline into if-semicolon-then-newline.

Aside from that, it does look better with the deeper case-body indent.



Messages sorted by: Reverse Date, Date, Thread, Author