Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH: improve wording in gpg completion
- X-seq: zsh-workers 41603
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: William da Silva <w.vigolodasilva@xxxxxxxxx>, zsh-workers@xxxxxxx
- Subject: Re: PATCH: improve wording in gpg completion
- Date: Fri, 25 Aug 2017 15:31:40 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=UUL5bE /ZVtVj06PsWxrHdKwhkVRYReSbVT33rB8j6Lk=; b=GsrPDnT2t2wnWgxD5TdoVr 86PJHF0Bo89H6w9mt2sURGRycYXRm5rP1hEpqIJYXiXmqZ6RtTqH4w/SkGyjN/pu 7SrNRn2HN1L6ZEW513TsGiMlR7TpxbwwYuO2o75IjaNz3BA3EV3+EFgMjRXYX1x2 DWiFVE6zpcPE1lLDJTD0gKOzJMAcrs6DI6ilVIXEUYkHeaJ0/b3VEzYv/WPMHY4U /2g5h7VVdCQ8nzya0cZi1XFFNaeDvt0W6/BaGn3twbzQ5av6r8rvX2yrIv5MNTyD OLfcifE4NWr9GqbI5fBW5pI+6FcqYuMcoQ+sVdVqkqI2PkYzc4+NUBMxYgnWLXGA ==
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=UUL5bE /ZVtVj06PsWxrHdKwhkVRYReSbVT33rB8j6Lk=; b=OGtPXdtE+bPCU1YzUMaTwr bK1tuCvDjRU3ilprrVXJKTORAk2awvDLiz501i7HlCH5XsQqWes3s1NmM9HAdTqz YZYIz5qP+PK9EIBnVSvASS37ndTTcPQ4c/QJweZgIq9JC0d36RnnL0SEz8XqFZlp etU0Bo0YsudVtvAUitClHWe1Sc8IYk4KCqwFPb8RgkVcRJmaulux63bVJb5Emlv8 82fUf/V63aj3Owttmk3oIM02Xo/q7COnh8KZ+VYqEx6HK9KXAlOnKhy+fNbljSEp Gr5AlVf3tmerbaKE6A8FLz7b9spQVjdQtWg6fQ355AkfvGk5/71V6dCLic3/IjQA ==
- In-reply-to: <CA+Jfsb98DdZB19UXS+RkBqTLzKRxtnOZkgWXX0-sC04NCVMQRw@mail.gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <CA+Jfsb98DdZB19UXS+RkBqTLzKRxtnOZkgWXX0-sC04NCVMQRw@mail.gmail.com>
William da Silva wrote on Fri, 25 Aug 2017 14:31 +0000:
> diff --git a/Completion/Unix/Command/_gpg b/Completion/Unix/Command/_gpg
> index fe6084f20..44db5e039 100644
> --- a/Completion/Unix/Command/_gpg
> +++ b/Completion/Unix/Command/_gpg
> @@ -26,7 +26,7 @@ fi
> [[ $service = gpgv ]] || args+=(
> '(-e --encrypt)'{-e,--encrypt}'[encrypt data. this option may be
> combined with --sign]'
As you see, your MUA wrapped lines hard, which breaks patches. When
sending patches, either disable line wrapping and whitespace mangling or
send the patches as attachments named *.txt.
> {-d,--decrypt}'[decrypt file or stdin]'
> - '(-c --symmetric)'{-c,--symmetric}'[encrypt with symmetric cypher only]'
> + '(-c --symmetric)'{-c,--symmetric}'[encrypt with symmetric cipher only]'
The man page uses the "cipher" spelling so okay.
> - '--fast-import[import a file without build trustdb]:_files
> attachment:_files'
> + '--fast-import[import a file without adding to trust database]:_files
"trustdb" is used as a noun in the man page so I think we should use it as a
noun here, too. I've omitted this and committed the rest with a tweak to
--edit-key. Thanks for the patch!
Daniel
Messages sorted by:
Reverse Date,
Date,
Thread,
Author