Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
pull requests for completion functions
- X-seq: zsh-workers 41998
- From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
- To: Zsh workers <zsh-workers@xxxxxxx>
- Subject: pull requests for completion functions
- Date: Thu, 09 Nov 2017 17:20:59 +0100
- Authentication-results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1510244475; bh=O0ezGt6aDvSJM/eWt6WUp20kaRy6c/PG5CyOyVDDi20=; h=From:To:Subject:Date:From:Subject; b=CfXSVUPbUZggrejmilkBYYGfm+durx8QLG4qIliryaKFO79Nc6rzlBktQUQjh/Wq4QeL6Kg8Ece89QcHv8hEtUZfCtttInWQ+PtauHqzm75Lhmh1s7IUsZGby6sfYNGTunLRVcBWq3Y88bsoMffI65L4hTjcKe9hw4VejSC0bIzWTK7CFVwDOCY999SudLGBb/P6gQoziwl23hyVWrbyQtseNLsOMIXGA0JYBXE52fzNAj6qzRDnoAVFd8S2OlykncXf9Y/P9eMmYWmdWTNWWP+8VIsyYipTOCplyLQacYMKDecp2gp26xQHFDiOrN86hCh3YI81i73N6dLa3nVhqw==
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- List-unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
I have tentatively added a short line to the bottom of the contributing
section of the web pages to indicate that completions are acceptable in
the form of pull/merge requests. The link is here:
http://zsh.sourceforge.net/Arc/git.html
Can I take silence to mean that people were happy with my suggestion on
this new policy? If not then please speak now, reverting the web page is
easily done.
My intended procedure for managing pull requests is as follows.
First you need to add separate remote repositories:
git remote add gitlab https://gitlab.com/zsh-org/zsh.git
git remote add github https://github.com/zsh-users/zsh.git
There's a variety of ways to fetch pull requests directly but I add a line
in .git/config under each section:
under: [remote "gitlab"]
add: fetch = +refs/merge-requests/*/head:refs/remotes/gitlab/merge-requests/*
under: [remote "github"]
add: fetch = +refs/pull/*:refs/remotes/github/pr/*
Many projects use merges but, to keep things as consistent as possible
with current practices, for now I would cherry-pick individual pull
requests and amend the commit to add a ChangeLog entry and reference
to the commit message. For ChangeLog entries and commit messages, the
references might be something like "MR: #1". Or do we need to be more
explicit, e.g. "github PR: #1"?
Any comments or suggestions would be welcome.
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author